Skip to content

[SYCL] enhance argsort for UT #17573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SYCL] enhance argsort for UT #17573

wants to merge 1 commit into from
+9 −2

Conversation

@NeoZhangJianyu
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu commented Nov 28, 2025

Fix the crash in CI.
Skip the UT cases which need local share memory than device's capability.
Make the supported cases are passed 100%.

@NeoZhangJianyu NeoZhangJianyu changed the title [sycl] enhance argsort for UT [SYCL] enhance argsort for UT Nov 28, 2025
@NeoZhangJianyu
Copy link
Collaborator Author

NeoZhangJianyu commented Nov 28, 2025

@slaren
Could you help review it?
No more SYCL reviewers with write permission now.

CISC
CISC approved these changes Nov 28, 2025
View reviewed changes
Copy link
Collaborator

@CISC CISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slaren is taking a break

@CISC CISC removed the request for review from slaren November 28, 2025 13:32
@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NeoZhangJianyu @CISC @arthw