use CredComponent for PullComponent via RefCell shared with main app #688
Conversation
298f4c8 to
aeea25a
Compare
|
@extrawurst I know this is probably annoying. But can you give this another approval ? (Thinking of another smaller PR just become a contributor before trying to work further on this on) |
…th main app this allow the CredComponent to be reused across the all other components. Since at any time only one using compoenent (here PullComponent only for now) is visible only one these sharing entities will try to get hold of the shared component via the RefCell
…th main app This component is shared with pullcomponent, which was updated also updated to use it via this shared instance.
this is shared object with PullComponent and PushComponent
aeea25a to
1bf96f7
Compare
|
@extrawurst any input on this ? |
|
[try 2] @extrawurst does this go in the right direction ? |
sorry for not giving you feedback on this yet, I hope to be able to on the weekend |
|
Is this still relevant ( even after resolving the conflicts) ? |
|
This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions. |
this allow the CredComponent to be reused across the all other
components.
Since at any time only one using compoenent (here PullComponent only for
now) is visible only one these sharing entities will try to get hold of
the shared component via the RefCell