Fix wrong condition in x11key Lookup for ASCII code#12
Fix wrong condition in x11key Lookup for ASCII code#12misak113 wants to merge 1 commit intogolang:masterfrom
Conversation
misak113
commented
Dec 29, 2020
- the condition was never met because rune is usually unsigned int
- the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
* the condition was never met because rune is usually unsigned int * the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80
f6d7d0e to
ec7f029
Compare
|
This PR (HEAD: ec7f029) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/exp/+/280752 to see it. Tip: You can toggle comments from me using the |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/280752. |