Open
Conversation
* the condition was never met because rune is usually unsigned int * the logical result of checking whether unshifted key rune is ASCII is range from 0 to 0x80
* The most appropriate description here: https://unix.stackexchange.com/a/55154/440266 * Right Alt ~ AltGr ~ ISO level 3 shift (but just for back compatibility) * in new sense the SwitchMode is replaced by XK_ISO_Group_Shift and aliases in some languages (keyboard layouts)
* adjust package comments to match golint
* it's alternativelly code for menu (not GUI)
… switch modes * it's currently using default bits reserved for switch modes & caps/num lock by X11. * However, it can differs depend on keyboard layout. The real bit values are available in KeysymTable. * but this change woul mean change of interface
Contributor
|
This PR (HEAD: 73e0679) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/exp/+/281256 to see it. Tip: You can toggle comments from me using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just proposal of new modifiers & key code for props.
It's currently in discussion of PR here: golang/mobile#61