fix: /chat save command silently fails on invalid tags #2839

greycodee · 2025-07-01T13:54:45Z

TLDR

Dive Deeper

Reviewer Test Plan

Testing Matrix

	🍏	🪟	🐧
npm run	✅	✅	✅
npx	✅	✅	✅
Docker	✅	✅	✅
Podman	✅	-	-
Seatbelt	✅	-	-

Linked issues / bugs

fix: #2819

gemini-code-assist

Summary of Changes

Hello @greycodee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user experience issue by enhancing the /chat save command. It introduces necessary input validation for the tag argument, ensuring that users are immediately notified with clear error messages if they provide an invalid or missing tag, thus preventing silent failures and improving the command's usability.

Highlights

Input Validation: Implemented validation for the tag argument of the /chat save command. The tag must now conform to the regex ^[a-zA-Z0-9_-]+$, allowing only letters, numbers, hyphens, and underscores.
Improved User Feedback: Added explicit error messages to inform users when a tag is invalid or missing for the /chat save command. This prevents the command from silently failing and provides clear guidance to the user.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly adds validation to the /chat save command to prevent it from failing silently with invalid tags. This also implicitly fixes a critical path traversal security vulnerability. My review points out that the same vulnerability exists in the /chat resume command and recommends extending the fix to cover that case as well.

packages/cli/src/ui/hooks/slashCommandProcessor.ts

abhipatel12

Hey! Sorry this took me so long to get to. This looks great!

Can we add some test cases that validate/test this?

greycodee · 2025-07-04T01:36:19Z

Hey! Sorry this took me so long to get to. This looks great!

Can we add some test cases that validate/test this?

I have now added the relevant tests for the chat command.

greycodee · 2025-07-06T00:47:59Z

/gemini review

gemini-code-assist

Code Review

This pull request fixes a silent failure in the /chat save command by adding validation for the provided tag. A high-severity suggestion was added to also validate the length of the tag to prevent potential filesystem errors with overly long filenames, which could lead to an application crash. This improves the robustness of the fix.

gemini-code-assist · 2025-07-06T00:49:45Z

packages/cli/src/ui/hooks/slashCommandProcessor.ts

+              const validTagRegex = /^[a-zA-Z0-9_-]+$/;
+              if (!validTagRegex.test(tag)) {
+                addMessage({
+                  type: MessageType.ERROR,
+                  content: 'Invalid tag. Only letters, numbers, hyphens, and underscores are allowed.',
                  timestamp: new Date(),
                });
                return;


The current validation for the tag checks for valid characters but not for length. An excessively long tag could lead to errors when creating the checkpoint file, as file systems have filename length limitations. Enforce a reasonable maximum length for the tag to prevent potential filesystem errors and application crashes.

Suggested change

const validTagRegex = /^[a-zA-Z0-9_-]+$/;

if (!validTagRegex.test(tag)) {

addMessage({

type: MessageType.ERROR,

content: 'Invalid tag. Only letters, numbers, hyphens, and underscores are allowed.',

timestamp: new Date(),

});

return;

const validTagRegex = /^[a-zA-Z0-9_-]{1,200}$/;

if (!validTagRegex.test(tag)) {

addMessage({

type: MessageType.ERROR,

content:

'Invalid tag. Tag must be 1-200 characters and contain only letters, numbers, hyphens, and underscores.',

timestamp: new Date(),

});

return;

}

greycodee · 2025-07-08T09:12:31Z

@abhipatel12 I found that your refactored code has been merged into #3175. Is the current PR still needed?

abhipatel12 · 2025-07-08T14:12:15Z

Hey @greycodee! I didn't change any of the logic within /chat for this initial migration in that refactor. Would you be able to see if main still has the issue you were tackling?

greycodee · 2025-07-08T15:01:09Z

@abhipatel12 I merged the refactored command code and modified the test code of the /chat command

abhipatel12 · 2025-07-08T15:04:33Z

Awesome, thanks for doing that. I will have some time to review later today!

greycodee · 2025-07-30T07:18:09Z

The code version has been refactored and this branch is no longer needed.

fix: /chat save command silently fails on invalid tags

2b857da

greycodee requested a review from a team as a code owner July 1, 2025 13:54

gemini-code-assist bot reviewed Jul 1, 2025

View reviewed changes

packages/cli/src/ui/hooks/slashCommandProcessor.ts Outdated Show resolved Hide resolved

fix: /chat save command silently fails on invalid tags

0feb4a0

allenhutchison requested a review from abhipatel12 July 1, 2025 21:57

allenhutchison assigned abhipatel12 Jul 1, 2025

greycodee added 3 commits July 2, 2025 10:32

Merge branch 'main' into fix/chat-save-tag-format

ef0ab80

Merge branch 'main' into fix/chat-save-tag-format

7c0bee2

Merge branch 'main' into fix/chat-save-tag-format

a9da364

gemini-cli bot added kind/bug priority/p1 Important and should be addressed in the near term. area/core Issues related to User Interface, OS Support, Core Functionality labels Jul 3, 2025

greycodee added 2 commits July 3, 2025 16:40

Merge branch 'main' into fix/chat-save-tag-format

c6b01a1

Merge branch 'main' into fix/chat-save-tag-format

60fcb11

abhipatel12 requested changes Jul 3, 2025

View reviewed changes

greycodee added 4 commits July 4, 2025 01:00

Merge branch 'main' into fix/chat-save-tag-format

c75d925

Merge branch 'main' into fix/chat-save-tag-format

74d7bb0

test: add /chat command tests

347c37a

Merge branch 'main' into fix/chat-save-tag-format

c883206

greycodee requested a review from abhipatel12 July 4, 2025 01:36

greycodee added 4 commits July 4, 2025 13:18

Merge branch 'main' into fix/chat-save-tag-format

679e6e8

Merge branch 'main' into fix/chat-save-tag-format

f6eb9f0

Merge branch 'main' into fix/chat-save-tag-format

2d87997

Merge branch 'main' into fix/chat-save-tag-format

e91772c

gemini-code-assist bot reviewed Jul 6, 2025

View reviewed changes

greycodee added 2 commits July 8, 2025 23:55

resolved conflicts

6d3b74e

remove unnecessary code

5a7c05e

greycodee added 4 commits July 9, 2025 03:07

Merge branch 'main' into fix/chat-save-tag-format

ebd42de

Merge branch 'main' into fix/chat-save-tag-format

4bd710e

Merge branch 'main' into fix/chat-save-tag-format

10e34b0

Merge branch 'main' into fix/chat-save-tag-format

9b26332

gemini-cli bot added kind/issue-triage priority/p2 Important but can be addressed in a future release. and removed priority/p1 Important and should be addressed in the near term. labels Jul 17, 2025

greycodee closed this Jul 30, 2025

greycodee deleted the fix/chat-save-tag-format branch July 30, 2025 07:18

fix: /chat save command silently fails on invalid tags #2839

fix: /chat save command silently fails on invalid tags #2839

Uh oh!

Conversation

greycodee commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

Dive Deeper

Reviewer Test Plan

Testing Matrix

Linked issues / bugs

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

abhipatel12 left a comment

Choose a reason for hiding this comment

Uh oh!

greycodee commented Jul 4, 2025

Uh oh!

greycodee commented Jul 6, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 6, 2025

Choose a reason for hiding this comment

Uh oh!

greycodee commented Jul 8, 2025

Uh oh!

abhipatel12 commented Jul 8, 2025

Uh oh!

greycodee commented Jul 8, 2025

Uh oh!

abhipatel12 commented Jul 8, 2025

Uh oh!

greycodee commented Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greycodee commented Jul 1, 2025 •

edited

Loading