Skip to content

Conversation

@iuga
Copy link

@iuga iuga commented Jan 14, 2026

Previously, attempting to delete a session with related events failed on Postgres due to a foreign key constraint violation. This commit adds OnDelete:CASCADE to the GORM relationship between sessions and events, ensuring that deleting a session will also remove its associated events. This resolves errors encountered during session deletion and allows safe cleanup of sessions with related events. Related to ~> #482

database error during session deletion: 
ERROR: update or delete on table "sessions" violates foreign key constraint "fk_sessions_events" on table "events" (SQLSTATE 23503)

Previously, attempting to delete a session with related events failed due to a foreign key constraint violation.
This commit adds `OnDelete:CASCADE` to the GORM relationship between sessions and events, ensuring that deleting a session will also remove its associated events.
This resolves errors encountered during session deletion and allows safe cleanup of sessions with related events.
@google-cla
Copy link

google-cla bot commented Jan 14, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iuga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical database issue where deleting a session would fail if it had associated events, leading to foreign key constraint violations. By introducing a cascading delete mechanism on the session-event relationship, the system now automatically removes all related events when a session is deleted, ensuring data consistency and preventing errors during session cleanup operations.

Highlights

  • Database Integrity: Implemented OnDelete:CASCADE for the Events relationship in storageSession to automatically delete associated events when a session is removed.
  • Error Resolution: Fixed a foreign key constraint violation error that occurred when attempting to delete sessions with related events in Postgres.
  • Data Cleanup: Ensures proper and safe cleanup of session data by automatically removing dependent event records.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly resolves a foreign key constraint violation that occurred when deleting a session with associated events. By adding the constraint:OnDelete:CASCADE to the GORM struct tag, the database will now automatically delete related events when a session is deleted. The change is correct and follows best practices for handling such relationships in GORM. To improve test coverage and prevent future regressions, I recommend adding a new test case to session/database/service_test.go that specifically verifies this cascade deletion behavior. The test should create a session with events, delete the session, and then assert that the events have also been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant