Retry pselect on EINTR #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go runtime may send signals to pause goroutines and these signals can interrupt pselect6. When this happens, the syscall returns EINTR. This change handles that case by retrying pselect6 on EINTR. The same approach is used by the mdlayher/socket library for sendmsg/recvmsg operations: https://github.com/mdlayher/socket/blob/8e6558649a7bd11ca1bd2b82c45fc96dee4dc11d/conn.go#L871.
stapelberg
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go runtime may send signals to pause goroutines and these signals can interrupt pselect6. When this happens, the syscall returns EINTR. This change handles that case by retrying pselect6 on EINTR. The same approach is used by the mdlayher/socket library for sendmsg/recvmsg operations:
https://github.com/mdlayher/socket/blob/8e6558649a7bd11ca1bd2b82c45fc96dee4dc11d/conn.go#L871.
Should fix the bug spotted on #339. I tested by doing something like this:
and simultaneously using
tail -f, looking for keywords on the file. It seems that very rarely ( maybe 5% of time time ) the exact same test would fail because of EINTR.