feat(firestore): change Type string union to raw string#7621
Merged
Conversation
**Breaking Change** The `type` string union is being replaced with a raw string. This is used in the `type` and `isType` expressions. The impact of this breaking change is expected to be very small, since `Type` is a string union, so it doesn't need to be imported to be used, and it's not a return value for any functions.
Type string union to raw stringType string union to raw string
Type string union to raw stringType string union to raw string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beta API Breaking Change The
Typestring union is being replaced with a raw string. This is used in thetypeandisTypePipeline expressions. This breaking change is allowed since Firestore Pipelines is currently in Public Preview.The impact of this breaking change is expected to be very small, since
Typeis a string union, so it doesn't need to be imported to be used, and it's not a return value for any functions. It's primarily used to give type hints to users.