BigQuery Datatransfer: Add 'DatasourceServiceClient'; add 'start_manual_transfer_runs' method; add 'client_info'/'version_info' support; allow passing kwargs to 'create_channel'; add path helpers (via synth). #8630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the API or client library generator.
e396b27 to
6259eee
Compare
Contributor
|
Thanks @tseaver Looks like the unit and system tests are passing. What should we do about the cover failures? |
tswast
approved these changes
Jul 15, 2019
Contributor
|
@tswast I would prefer that we add tests for the "stub" module, likely via autogen. E.g.: # tests/unit/test_him.py
def test_shim():
from google.cloud import bigquery_datatransfer
from google.cloud import bigquery_datatransfer_v1
assert bigquery_datatransfer.__all__ == bigquery_datatransfer_v1.__all__
for name in bigquery_datatransfer.__all__:
found = getattr(bigquery_datatransfer, name)
expected = getattr(bigquery_datatransfer_v1, name)
assert found is expected |
Contributor
|
Thanks @tseaver. I pushed a commit with this as a manual test. I've filed https://github.com/googleapis/gapic-generator/issues/2876 for the gapic generator to add such a test. |
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
…d; add `client_info`/`version_info` support; allow passing kwargs to `create_channel`; add path helpers (via synth). (#8630) * Add `DatasourceServiceClient`; add `start_manual_transfer_runs` method; add `client_info`/`version_info` support; allow passing kwargs to `create_channel`; add path helpers (via synth). * Add manual unit test for versionless import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Here's the log from Synthtool: