Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

feat(bigquery): Implement getArray in BigQueryResultImpl #3693

Merged
whuffman36 merged 11 commits into from
Mar 7, 2025
Merged

feat(bigquery): Implement getArray in BigQueryResultImpl #3693

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
81bd136
Implement getArray in BigQueryResultImpl
whuffman36 Feb 25, 2025
4e28b42
deps: update dependency com.google.apis:google-api-services-bigquery …
renovate-bot Feb 21, 2025
dc3c0fb
build(deps): update dependency org.apache.maven.plugins:maven-compile…
renovate-bot Feb 21, 2025
8011eaf
deps: update ossf/scorecard-action action to v2.4.1 (#3690)
renovate-bot Feb 24, 2025
fac2ae1
deps: update actions/upload-artifact action to v4.6.1 (#3691)
renovate-bot Feb 24, 2025
aa73bfd
Remove public from BigQueryResultSet class def
whuffman36 Feb 26, 2025
3b4791d
Remove INTEGER_ARRAY_FIELD_LIST from IT test file
whuffman36 Feb 26, 2025
a32c123
Add ReadApi IT test
whuffman36 Mar 3, 2025
34c59df
Try old IT test values
whuffman36 Mar 4, 2025
2fc76c8
Convert Time objects to strings for comparison
whuffman36 Mar 4, 2025
5416a1a
Fix Formatting
whuffman36 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try old IT test values
  • Loading branch information
@whuffman36
whuffman36 committed Mar 4, 2025
commit 34c59dfb5416a2acf1f31c90f43aff6a8844464f
7 changes: 2 additions & 5 deletions google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
View file
Open in desktop

@PhongChuong PhongChuong Feb 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of the modified integration tests exercise the non-ReadAPI path. Can you check if we have an existing integration test that exercise the read API path and augment the test to validate getArray on it?

@whuffman36 whuffman36 Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a new IT test to test the ReadAPI path. Turns out that path had not been tested yet, and so the expected responses for getDate() and getTime() were inaccurate. The ReadAPI path returns the Date and Time objects in local format instead of UTC format.

@whuffman36 whuffman36 Mar 4, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, it looks more like my local machine had a different local time than that of the VM running the kokoro, resulting in different dates and time objects. This has been resolved.

Original file line number Diff line number Diff line change
Expand Up @@ -3981,13 +3981,10 @@ public void testExecuteSelectSinglePageTableRowWithReadAPI() throws SQLException
assertNotNull(rs.getBytes("BytesField"));
assertEquals(1, rs.getInt("IntegerField"));
assertEquals(1534680695123L, rs.getTimestamp("TimestampField").getTime());
assertEquals(
java.sql.Date.valueOf("2018-08-18").toLocalDate(), rs.getDate("DateField").toLocalDate());
assertEquals(java.sql.Date.valueOf("2018-08-19"), rs.getDate("DateField"));
assertTrue(rs.getDouble("FloatField") == 10.1d);
assertTrue(rs.getDouble("NumericField") == 100.0d);
assertEquals(
Time.valueOf(LocalTime.of(4, 11, 35, 123456)).toLocalTime(),
rs.getTime("TimeField").toLocalTime());
assertEquals(Time.valueOf(LocalTime.of(12, 11, 35, 123456)), rs.getTime("TimeField"));
assertEquals("2018-08-19T12:11:35.123456", rs.getString("DateTimeField"));
assertEquals("POINT(-122.35022 47.649154)", rs.getString("GeographyField"));
assertNotNull(rs.getBytes("BytesField_1"));
Expand Down