Skip to content

fix: Persist missingValueInterpretationMap in StreamWriter's Builder #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix: Persist missingValueInterpretationMap in StreamWriter's Builder #2587

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5d93ae
Persist missingValueInterpretationMap in StreamWriter's Builder. In c…
yifatgortler Jul 30, 2024
94cb8d0
Fix format
yifatgortler Jul 30, 2024
99a6a88
Addressed comments: Revived the getMissingValueInterpretationMap meth…
yifatgortler Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix format
  • Loading branch information
@yifatgortler
yifatgortler committed Sep 25, 2024
commit 94cb8d02b678fa8639ebd339ead07d0248efa26f
3 changes: 2 additions & 1 deletion ...-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,8 @@ public void testAppendWithoutMissingValueMap() throws Exception {
assertEquals(0, responseFuture.get().getAppendResult().getOffset().getValue());

verifyAppendRequests(1);
assertTrue(testBigQueryWrite.getAppendRequests().get(0).getMissingValueInterpretations().isEmpty());
assertTrue(
testBigQueryWrite.getAppendRequests().get(0).getMissingValueInterpretations().isEmpty());
}
}

Expand Down