Skip to content
This repository was archived by the owner on Feb 24, 2026. It is now read-only.

Add 'Received Rst Stream' to automatic retry strings #419

Merged
stephaniewang526 merged 2 commits into from
Jul 15, 2020
Merged

Add 'Received Rst Stream' to automatic retry strings #419

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7156e6
Add 'Received Rst Stream' to automatic retry strings
kmjung Jul 15, 2020
a3d6ae0
Run 'mvn com.coveo:fmt-maven-plugin:format'
kmjung Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run 'mvn com.coveo:fmt-maven-plugin:format'
  • Loading branch information
@kmjung
kmjung committed Jul 15, 2020
commit a3d6ae06846e6ff70c5214c5b51ea039afb68734
2 changes: 1 addition & 1 deletion ...main/java/com/google/cloud/bigquery/storage/v1/stub/readrows/ApiResultRetryAlgorithm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private boolean isRetryableStatus(Status status) {
return status.getCode() == Status.Code.INTERNAL
&& status.getDescription() != null
&& (status.getDescription().contains("Received unexpected EOS on DATA frame from server")
|| status.getDescription().contains("Received Rst Stream"));
|| status.getDescription().contains("Received Rst Stream"));
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion ...java/com/google/cloud/bigquery/storage/v1beta2/stub/readrows/ApiResultRetryAlgorithm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private boolean isRetryableStatus(Status status) {
return status.getCode() == Status.Code.INTERNAL
&& status.getDescription() != null
&& (status.getDescription().contains("Received unexpected EOS on DATA frame from server")
|| status.getDescription().contains("Received Rst Stream"));
|| status.getDescription().contains("Received Rst Stream"));
}

@Override
Expand Down
6 changes: 4 additions & 2 deletions ...erystorage/src/test/java/com/google/cloud/bigquery/storage/v1/BigQueryReadClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ public void readRowsRetryingEOSExceptionTest() throws ExecutionException, Interr
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"Received unexpected EOS on DATA frame from server")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryRead.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand All @@ -198,7 +199,8 @@ public void readRowsRetryingHttp2StreamRstTest() throws ExecutionException, Inte
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"HTTP/2 error code: INTERNAL_ERROR\nReceived Rst Stream")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryRead.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand Down
6 changes: 4 additions & 2 deletions ...ge/src/test/java/com/google/cloud/bigquery/storage/v1beta1/BigQueryStorageClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ public void readRowsRetryingEOSExceptionTest() throws ExecutionException, Interr
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"Received unexpected EOS on DATA frame from server")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryStorage.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand All @@ -328,7 +329,8 @@ public void readRowsRetryingHttp2StreamRstTest() throws ExecutionException, Inte
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"HTTP/2 error code: INTERNAL_ERROR\nReceived Rst Stream")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryStorage.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand Down
6 changes: 4 additions & 2 deletions ...orage/src/test/java/com/google/cloud/bigquery/storage/v1beta2/BigQueryReadClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,8 @@ public void readRowsRetryingEOSExceptionTest() throws ExecutionException, Interr
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"Received unexpected EOS on DATA frame from server")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryRead.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand All @@ -198,7 +199,8 @@ public void readRowsRetryingHttp2StreamRstTest() throws ExecutionException, Inte
new StatusRuntimeException(
Status.INTERNAL.withDescription(
"HTTP/2 error code: INTERNAL_ERROR\nReceived Rst Stream")),
GrpcStatusCode.of(Code.INTERNAL), /* retryable = */ false);
GrpcStatusCode.of(Code.INTERNAL),
/* retryable = */ false);
mockBigQueryRead.addException(exception);
long rowCount = 1340416618L;
ReadRowsResponse expectedResponse = ReadRowsResponse.newBuilder().setRowCount(rowCount).build();
Expand Down