Skip to content

chore: running integration test with Protobuf 4.29.4 [no need to review] #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 44 additions & 44 deletions .github/workflows/hermetic_library_generation.yaml
Original file line number Diff line number Diff line change
@@ -1,45 +1,45 @@
# Copyright 2024 Google LLC
## Copyright 2024 Google LLC
##
## Licensed under the Apache License, Version 2.0 (the "License");
## you may not use this file except in compliance with the License.
## You may obtain a copy of the License at
##
## http://www.apache.org/licenses/LICENSE-2.0
##
## Unless required by applicable law or agreed to in writing, software
## distributed under the License is distributed on an "AS IS" BASIS,
## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
## See the License for the specific language governing permissions and
## limitations under the License.
## GitHub action job to test core java library features on
## downstream client libraries before they are released.
#name: Hermetic library generation upon generation config change through pull requests
#on:
# pull_request:
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# GitHub action job to test core java library features on
# downstream client libraries before they are released.
name: Hermetic library generation upon generation config change through pull requests
on:
pull_request:

env:
REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
GITHUB_REPOSITORY: ${{ github.repository }}
jobs:
library_generation:
runs-on: ubuntu-latest
steps:
- name: Determine whether the pull request comes from a fork
run: |
if [[ "${GITHUB_REPOSITORY}" != "${REPO_FULL_NAME}" ]]; then
echo "This PR comes from a fork. Skip library generation."
echo "SHOULD_RUN=false" >> $GITHUB_ENV
else
echo "SHOULD_RUN=true" >> $GITHUB_ENV
fi
- uses: actions/checkout@v4
if: env.SHOULD_RUN == 'true'
with:
fetch-depth: 0
token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
- uses: googleapis/sdk-platform-java/.github/[email protected]
if: env.SHOULD_RUN == 'true'
with:
base_ref: ${{ github.base_ref }}
head_ref: ${{ github.head_ref }}
token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
#env:
# REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}
# GITHUB_REPOSITORY: ${{ github.repository }}
#jobs:
# library_generation:
# runs-on: ubuntu-latest
# steps:
# - name: Determine whether the pull request comes from a fork
# run: |
# if [[ "${GITHUB_REPOSITORY}" != "${REPO_FULL_NAME}" ]]; then
# echo "This PR comes from a fork. Skip library generation."
# echo "SHOULD_RUN=false" >> $GITHUB_ENV
# else
# echo "SHOULD_RUN=true" >> $GITHUB_ENV
# fi
# - uses: actions/checkout@v4
# if: env.SHOULD_RUN == 'true'
# with:
# fetch-depth: 0
# token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
# - uses: googleapis/sdk-platform-java/.github/[email protected]
# if: env.SHOULD_RUN == 'true'
# with:
# base_ref: ${{ github.base_ref }}
# head_ref: ${{ github.head_ref }}
# token: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
1 change: 1 addition & 0 deletions .kokoro/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ javadoc)
integration)
mvn -B ${INTEGRATION_TEST_ARGS} \
-ntp \
-Dprotobuf.version=4.29.4 \
-Penable-integration-tests \
-DtrimStackTrace=false \
-Dclirr.skip=true \
Expand Down