Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

samples: move AutoML vision samples from nodejs-vision#134

Merged
JustinBeckwith merged 9 commits into
masterfrom
vision-samples
Feb 26, 2019
Merged

samples: move AutoML vision samples from nodejs-vision#134
JustinBeckwith merged 9 commits into
masterfrom
vision-samples

Conversation

@jkwlui
Copy link
Copy Markdown
Contributor

@jkwlui jkwlui commented Feb 21, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@jkwlui jkwlui changed the title samples: move automl vision samples here samples: move AutoML vision samples from nodejs-vision Feb 21, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2019

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #134   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b52f6c8...cd50c33. Read the comment docs.

const sampleImage2 = path.join(testImgPath, `testImage2.jpg`);

describe(`auto ml vision`, () => {
it.skip(`should create, list, and delete a dataset`, async () => {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all skipped intentionally?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirupa-kumar @sirtorry are these all long running, e.g. which require model training? Or can any of these actions be performed rather instantaneously?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of them took longer to complete and the time duration had not been consistent. Some of them do require Model training. That was the reason we moved to skipping them. Please let me know if there is anything else we could do.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me rethink the tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants