Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

docs: move and update beta list samples for video#344

Merged
bcoe merged 4 commits into
masterfrom
automl-beta-list
Mar 17, 2020
Merged

docs: move and update beta list samples for video#344
bcoe merged 4 commits into
masterfrom
automl-beta-list

Conversation

@nnegrey

@nnegrey nnegrey commented Mar 13, 2020

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2020
@codecov

codecov Bot commented Mar 13, 2020

Copy link
Copy Markdown

Codecov Report

Merging #344 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #344   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files           7        7           
  Lines        7987     7987           
  Branches      253      253           
=======================================
  Hits         7167     7167           
  Misses        816      816           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2fdb3...e8a7b39. Read the comment docs.

@nnegrey nnegrey requested a review from bcoe March 13, 2020 19:29

@JustinBeckwith JustinBeckwith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to clean up region tags

);
// [END automl_video_classification_list_datasets_beta]

// [START automl_video_object_tracking_list_datasets_beta]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a weird place to start a snippet. Is that intentional?

Copy link
Copy Markdown
Contributor Author

Comment thread samples/beta/list-datasets.js
'use strict';

function main(projectId = 'YOUR_PROJECT_ID', location = 'us-central1') {
// [START automl_video_classification_list_datasets_beta]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own understanding - are these features available in the GA version of the API? Or only in the beta?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video flavor of AutoML is in beta along with Tables

But these other versions are in GA:

  • Language: Entity Extraction, Sentiment Analysis, Classification
  • Vision: Object Detection, Classification
  • Translate

@bcoe

bcoe commented Mar 16, 2020

Copy link
Copy Markdown

@nnegrey happy to help land these updates (I saw a few similar PRs) once @JustinBeckwith's comments are addressed. Please feel free to flag me once you're ready.

@bcoe bcoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnegrey we might want to eventually take the multiple-region-tags-in-one-file case into account when generating README files, based on region tags.

@bcoe bcoe merged commit 51b067b into master Mar 17, 2020
@bcoe bcoe deleted the automl-beta-list branch March 17, 2020 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants