Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

fix: fix generic error message when entering an incorrect column name #1031

Merged
chelsea-lin merged 7 commits into from
Oct 6, 2024
Merged

fix: fix generic error message when entering an incorrect column name #1031

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1acaae1
fix: fix generic error message when entering incorrect column name
arwas11 Sep 30, 2024
d87b6cd
fix varibale initialization
arwas11 Sep 30, 2024
b69868e
Merge remote-tracking branch 'origin/main' into b328113227-groupby-ge…
arwas11 Oct 1, 2024
30020ba
Add a test case
arwas11 Oct 2, 2024
71b23cc
Update code and fix failling tests
arwas11 Oct 3, 2024
04d2391
Add test case for multiple columns
arwas11 Oct 3, 2024
8bdcc56
Merge branch 'main' into b328113227-groupby-getitme-cloumn-name-error
chelsea-lin Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions bigframes/core/groupby/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,12 @@ def __getitem__(
keys = list(key)
else:
keys = [key]
columns = [
col_id for col_id, label in self._col_id_labels.items() if label in keys
]

for col_id, label in self._col_id_labels.items():
if label in keys:
columns = [col_id]
Comment thread
arwas11 marked this conversation as resolved.
Outdated
else:
raise KeyError(f"Columns not found: {str(keys)[1:-1]}")

if len(columns) > 1 or (not self._as_index):
return DataFrameGroupBy(
Expand Down