Skip to content

fix: Use exact median implementation by default #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2024
Merged

fix: Use exact median implementation by default #619

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3838811
fix: Use exact median implementation by default
TrevorBergeron Apr 17, 2024
79ce279
fix test_numeric_literal test
TrevorBergeron Apr 17, 2024
b7e8aa3
Merge remote-tracking branch 'github/main' into exact_median
TrevorBergeron Apr 18, 2024
dc85f8f
amend doc example
TrevorBergeron Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test_numeric_literal test
  • Loading branch information
@TrevorBergeron
TrevorBergeron committed Apr 17, 2024
commit 79ce279df242440fa6b06f928299d329f7f813e1
5 changes: 2 additions & 3 deletions tests/system/small/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,10 +1345,9 @@ def test_numeric_literal(scalars_dfs):
scalars_df, _ = scalars_dfs
col_name = "numeric_col"
assert scalars_df[col_name].dtype == pd.ArrowDtype(pa.decimal128(38, 9))
bf_result = scalars_df[col_name] - scalars_df[col_name].median()
bf_result = scalars_df[col_name] + 42
assert bf_result.size == scalars_df[col_name].size
# TODO(b/323387826): The precision increased by 1 unexpectedly.
# assert bf_result.dtype == pd.ArrowDtype(pa.decimal128(38, 9))
assert bf_result.dtype == pd.ArrowDtype(pa.decimal128(38, 9))


def test_repr(scalars_dfs):
Expand Down