Fixes float-conversion warning in ostream::putDouble.#538
Open
martinbudden wants to merge 1 commit intogreiman:masterfrom
Open
Fixes float-conversion warning in ostream::putDouble.#538martinbudden wants to merge 1 commit intogreiman:masterfrom
martinbudden wants to merge 1 commit intogreiman:masterfrom
Conversation
Owner
|
I will handle this fix like the fix for istream. Please try the following at line 92 of ostream,cpp: I will apply it to SdFat-beta and later to the release version of SdFat. |
Owner
|
Few people use the iostream part of SdFat and printf is not in many board packages. I don't use iostream much so I am playing with a variadic wrapper for anything derived from Print for my use. Here is an early test: Width() is like iostreams std::setw(), it only applies to the next field. Base() is like iosteram std::hex and std::dec, and Prec() is like std::setprecision(). Here is the output: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes warning that occurs when compiled with
-Wfloat-conversion.