Skip to content

interop/xds: Avoid setting unit suffixes #8479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arjan-bal wants to merge 1 commit into from
Closed

interop/xds: Avoid setting unit suffixes #8479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/features/csm_observability/client/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var (

func main() {
flag.Parse()
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
log.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion examples/features/csm_observability/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (s *server) SayHello(_ context.Context, in *pb.HelloRequest) (*pb.HelloRepl

func main() {
flag.Parse()
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
log.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion examples/features/opentelemetry/client/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ var (
)

func main() {
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
log.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion examples/features/opentelemetry/server/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func (s *echoServer) UnaryEcho(_ context.Context, req *pb.EchoRequest) (*pb.Echo
}

func main() {
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
log.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion interop/xds/client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func parseRPCMetadata(rpcMetadataStr string, rpcs []string) []*rpcConfig {
func main() {
flag.Parse()
if *enableCSMObservability {
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
logger.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
2 changes: 1 addition & 1 deletion interop/xds/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ func xdsServingModeCallback(addr net.Addr, args xds.ServingModeChangeArgs) {
func main() {
flag.Parse()
if *enableCSMObservability {
exporter, err := prometheus.New()
exporter, err := prometheus.New(prometheus.WithoutUnits())
if err != nil {
logger.Fatalf("Failed to start prometheus exporter: %v", err)
}
Expand Down
Loading