Skip to content

xds: parse ClusterSpecifierPlugin from RouteConfiguration in xDS response #8635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dapengzhang0 merged 6 commits into from
Jan 6, 2022
Merged

xds: parse ClusterSpecifierPlugin from RouteConfiguration in xDS response #8635

dapengzhang0 merged 6 commits into from
Jan 6, 2022

Conversation

@dapengzhang0
Copy link
Contributor

@dapengzhang0 dapengzhang0 commented Oct 28, 2021

Implement the xds Client section of go/grpc-rls-in-xds#heading=h.9kitavdfxxiw

@dapengzhang0 dapengzhang0 requested review from sergiitk and removed request for sergiitk October 28, 2021 20:10
@dapengzhang0
Copy link
Contributor Author

dapengzhang0 commented Oct 29, 2021 •
edited
Loading

Sorry, please hold on to review.
#8638 and a refactor is needed to fix a mistake from #8612 first.

@dapengzhang0 dapengzhang0 marked this pull request as draft November 12, 2021 18:26
@dapengzhang0 dapengzhang0 marked this pull request as ready for review December 6, 2021 18:12
@dapengzhang0 dapengzhang0 requested a review from sergiitk December 6, 2021 18:12
@dapengzhang0
Copy link
Contributor Author

dapengzhang0 commented Dec 6, 2021

Merged the fix and refactored accordingly. Now is ready for review.

sergiitk
sergiitk reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

@dapengzhang0 dapengzhang0 added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Jan 6, 2022
@grpc-kokoro grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Jan 6, 2022
@dapengzhang0 dapengzhang0 merged commit b32d2d2 into grpc:master Jan 6, 2022
@dapengzhang0 dapengzhang0 deleted the xds-rls branch January 6, 2022 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees

No one assigned

Labels

Type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dapengzhang0 @sergiitk @grpc-kokoro