Skip to content

Make release 1.44.1 #8929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanjaypujare merged 3 commits into from
Feb 18, 2022
Merged

Make release 1.44.1 #8929

sanjaypujare merged 3 commits into from
Feb 18, 2022

Conversation

@sanjaypujare
Copy link
Contributor

@sanjaypujare sanjaypujare commented Feb 17, 2022

No description provided.

@sanjaypujare sanjaypujare requested a review from ejona86 February 17, 2022 22:58
@ejona86
Copy link
Member

ejona86 commented Feb 17, 2022

There should be three commits here. It seems like the commit that would have the tag itself is missing.

There should be:
Update README etc to reference $MAJOR.$MINOR.$PATCH (present)
Bump version to $MAJOR.$MINOR.$PATCH (missing)
Bump version to $MAJOR.$MINOR.$((PATCH+1))-SNAPSHOT (present)

@ejona86 ejona86 mentioned this pull request Feb 17, 2022
Merged
@sanjaypujare
Copy link
Contributor Author

sanjaypujare commented Feb 18, 2022

Oops, sorry. Fixed it. PTAL

There should be three commits here. It seems like the commit that would have the tag itself is missing.

There should be: Update README etc to reference $MAJOR.$MINOR.$PATCH (present) Bump version to $MAJOR.$MINOR.$PATCH (missing) Bump version to $MAJOR.$MINOR.$((PATCH+1))-SNAPSHOT (present)

@sanjaypujare sanjaypujare merged commit e147968 into grpc:v1.44.x Feb 18, 2022
@sanjaypujare sanjaypujare deleted the release branch March 21, 2022 03:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanjaypujare @ejona86