Hotfix/api manager fix #57
Conversation
…et-co/android into hotfix/api-manager-fix
|
🚀👀👀 |
josikie
left a comment
There was a problem hiding this comment.
Awesome, thanks! @andhikayuana
I have some questions, I'm curious
| private static final long SYNC_PERIOD = TimeUnit.HOURS.toMillis(24); | ||
| private static SyncProgressTask syncTask; | ||
| public boolean running; | ||
| public volatile boolean running; |
There was a problem hiding this comment.
Why does it get name volatile?
There was a problem hiding this comment.
in short, the change is immediately visible to other threads.
https://www.w3schools.com/java/ref_keyword_volatile.asp
| @Before | ||
| fun setUp() { | ||
| apiManager = spyk(APIManager(remoteConfigSource), recordPrivateCalls = true) | ||
| apiManager = spyk(BRApiManager(remoteConfigSource), recordPrivateCalls = true) |
There was a problem hiding this comment.
What is Spyke function, and how does it work?
There was a problem hiding this comment.
I did some googling...but you can take a look at this @josikie :
https://www.naukri.com/code360/library/mock-vs-stub-vs-spy
kcw-grunt
left a comment
There was a problem hiding this comment.
Looks ok for currrent users but there is a critical issue so that second PIN entry doesnt doesnt dimiss the view
Please see:
|
sure, will check it later |
thank you! |
Overview
Issue