[v4] Deposit Checks #12465
Open
[v4] Deposit Checks #12465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Luke-Oldenburg
left a comment
There was a problem hiding this comment.
I think we should add a show and index in this PR too.
Co-authored-by: Luke Oldenburg <[email protected]>
9739569 to
f73cf3d
Compare
Mohamad-Mortada
commented
Dec 27, 2025
Co-authored-by: Luke Oldenburg <[email protected]>
Co-authored-by: Luke Oldenburg <[email protected]>
Co-authored-by: Luke Oldenburg <[email protected]>
| resources :invoices, only: [:show, :create] | ||
|
|
||
| resources :sponsors, only: [:show, :create] | ||
| resources :check_deposits, path: "check-deposits", only: [:index, :show, :create] |
Contributor
There was a problem hiding this comment.
Suggested change
| resources :check_deposits, path: "check-deposits", only: [:index, :show, :create] | |
| resources :check_deposits, only: [:index, :show, :create] |
Comment on lines
+33
to
+35
| rescue ActiveRecord::RecordInvalid | ||
| return render json: { error: "invalid_operation", messages: @check_deposit.errors.full_messages }, status: :unprocessable_entity | ||
| end |
Contributor
There was a problem hiding this comment.
We don't need this rescue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Bank of America can deposit checks via their mobile app and we can't?! The shame...
Describe your changes
Created POST /
api/v4/organizations/xxxxxxx/check-depositswhich takes infront,back, andamount_centsCreated GET for
/api/v4/organizations/xxxxxxx/check-depositsfor index and show