[v4] allow freezing on stripe cards as grantees #12664
Open
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
reviewed
Jan 18, 2026
Comment on lines
+75
to
+77
| @stripe_card = StripeCard.find_by_public_id!(params[:id]) | ||
| # we authorize by show as actions are handled by their own policies (update interferes with this) | ||
| authorize @stripe_card, :show? |
Member
There was a problem hiding this comment.
this feels really unsafe. also, where are these policy calls being made?
sampoder
requested changes
Jan 18, 2026
Member
sampoder
left a comment
There was a problem hiding this comment.
we shouldn't be using the show? policy for updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
This is causing grantees to not be able to freeze their cards as
authorizefails on policy ofupdate. So we authorize at something more acceptable such asshow?and we handle policy per action (freeze, defrost, and activate). Ideally these shouldve been their own methods.Describe your changes
change inital authorize