Skip to content

update peerDependency #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hueniverse merged 2 commits into from
Mar 21, 2014
Merged

update peerDependency #2

hueniverse merged 2 commits into from
Mar 21, 2014

Conversation

@daviddias
Copy link
Contributor

@daviddias daviddias commented Mar 14, 2014

Simple PR, had to update the peerDependency, otherwise could not use with Hapi 3.0.

Tests say:

» npm test                  

> [email protected] test /Users/david/Dropbox/Code/nodesecurity/hapi-auth-basic
> make test-cov



  ......................

 22 tests complete (104 ms)



 No global variable leaks detected.

Coverage: 100.00%
Coverage succeeded

All seems pretty fine :) Also closes this one #1

pletcher
pletcher reviewed Mar 14, 2014
View reviewed changes
package.json Outdated
Copy link

@pletcher pletcher Mar 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this instead be ">=2.x.x" (and likewise below) to maintain backwards compatibility?

Copy link
Contributor Author

@daviddias daviddias Mar 14, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

@hueniverse hueniverse added this to the 1.0.1 milestone Mar 21, 2014
@hueniverse hueniverse self-assigned this Mar 21, 2014
hueniverse pushed a commit that referenced this pull request Mar 21, 2014
Merge pull request #2 from diasdavid/master
e579edb 
update peerDependency
@hueniverse hueniverse merged commit e579edb into hapijs:master Mar 21, 2014
@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@hueniverse hueniverse

Labels

feature New functionality or improvement

Projects

None yet

Milestone

1.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@daviddias @pletcher @hueniverse