Skip to content

Fixes --proxy without a protocol throwing an uncaught error #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 13, 2021
Merged

Fixes --proxy without a protocol throwing an uncaught error #742

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e368d6
Fixes #451
Ratcoder Oct 6, 2021
e8db8dc
Added test for issue #451
Ratcoder Oct 6, 2021
0ba1cb3
Made proxy url checker more general
Ratcoder Oct 11, 2021
5d55b6a
Removed accidental require()
Ratcoder Oct 11, 2021
6307b00
stylistic change
Ratcoder Oct 11, 2021
dbd607c
stylistic change
Ratcoder Oct 11, 2021
b80f3d3
Added missing comma
Ratcoder Oct 11, 2021
b9304ee
Merge branch 'master' into master
thornjad Oct 12, 2021
046fefa
Update test/cli.test.js
Ratcoder Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stylistic change 
Co-authored-by: Jade Michael Thornton <[email protected]>
  • Loading branch information
@Ratcoder @thornjad
Ratcoder and thornjad authored Oct 11, 2021
commit dbd607cf34b18436d4a0ddbe02f09f1a50aee83d
2 changes: 1 addition & 1 deletion bin/http-server
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ function listen(port) {

if (proxy) {
try {
new URL.URL(proxy)
new url.URL(proxy)
}
catch (err) {
logger.info(colors.red('Error: Invalid proxy url'));
Expand Down