Do not allow CRLF in headers #932
Merged
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the underlying HTTP server does in fact throw an error when the response will have invalid HTTP headers, this happens at runtime at the time of the first request rather than immediately after the process is started. This should be considered a fatal configuration error, causing the process to exit immediately.
|
Is this fixing a security vulnerability? If so, it should probably have a CVE number assigned to it. Thoughts? |
rafiibrahim8
pushed a commit
to rafiibrahim8/http-server
that referenced
this pull request
Oct 25, 2025
While the underlying HTTP server does in fact throw an error when the response will have invalid HTTP headers, this happens at runtime at the time of the first request rather than immediately after the process is started. This should be considered a fatal configuration error, causing the process to exit immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the underlying HTTP server does in fact throw an error when the response will have invalid HTTP headers, this happens at runtime at the time of the first request rather than immediately after the process is started. This should be considered a fatal configuration error, causing the process to exit immediately.
Relevant issues
Contributor checklist
--helpoutputmasterbranchMaintainer checklist