Skip to content

Conversation

@d-trace
Copy link
Contributor

@d-trace d-trace commented May 27, 2022

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@d-trace d-trace requested a review from a team as a code owner May 27, 2022 18:41
@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #145 (3bda7cb) into main (eff5a7d) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main     #145   +/-   ##
=========================================
  Coverage     22.77%   22.77%           
  Complexity       75       75           
=========================================
  Files            65       65           
  Lines          1739     1739           
  Branches         53       53           
=========================================
  Hits            396      396           
  Misses         1334     1334           
  Partials          9        9           
Flag Coverage Δ
unit 22.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lorer/dao/GatewayServiceExploreRequestBuilder.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eff5a7d...3bda7cb. Read the comment docs.

@d-trace d-trace merged commit 92fe78e into main May 27, 2022
@d-trace d-trace deleted the make_time_range_optional_in_explorer_2 branch May 27, 2022 21:36
@github-actions
Copy link

Unit Test Results

11 files  ±0  11 suites  ±0   15s ⏱️ -1s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 92fe78e. ± Comparison against base commit eff5a7d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants