Add GET API for confessions#21
Merged
iharshit009 merged 4 commits intoiharshit009:mainfrom Dec 9, 2020
Merged
Conversation
|
Hello @paramsiddharth! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-12-09 12:33:12 UTC |
Contributor
Author
|
The module level import is not at the top of the file because |
iharshit009
reviewed
Dec 9, 2020
api_routes/get.py
Outdated
| def get_confession(): | ||
| messages = Confessions.query.all() | ||
| messages_tuple = tuple(map(lambda confession: { | ||
| 'id': confession.id, |
Owner
There was a problem hiding this comment.
We also need to get a name along with the confession message
api_routes/get.py
Outdated
| from app import app, db, Confessions | ||
|
|
||
|
|
||
| @app.route('/api/get', methods=['GET']) |
Owner
There was a problem hiding this comment.
Can we write this function in the app.py file, where the POST function is written?
Contributor
Author
|
I have done the changes as required. Please review. |
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GET API for confessions
Resolves #2: GET API for all confessions
/api/getendpoint, which returns a list of all confessions made so far."id"field and a"title"field with the desired values.[{"id":6,"title":"I love to talk but not to random ones"},{"id":7,"title":"I have..."}]