fix(web): modal race condition #19625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 1, 2025 01:35
| onClose = async (...args: [StripValueIfOptional<K>]) => { | ||
| await unmount(modal); | ||
| resolve(args?.[0]); | ||
| setTimeout(() => resolve(args?.[0]), 0); |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
You tried this?
await tick();
resolve(args?.[0]);
Member
There was a problem hiding this comment.
tick is specific to svelte and has to deal with pending svelte ui updates & microtasks, which isn't what the cause of the problem is related to.
danieldietzler
approved these changes
Jun 30, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
* fix(web): modal race condition * fix: translation * fix: translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further fix for #18615.
See immich-app/ui#203.
In this PR,
@immich/uiis updated to release.