fix(web): prevent flashing white background in dark mode on page load/reload #19934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ested with Safari and Chrome on macOS
jrasm91
reviewed
Jul 15, 2025
web/src/app.html
Outdated
Comment on lines
104
to
106
| html.dark { background-color: rgb(10, 10, 10); } | ||
| html { background-color: rgb(255, 255, 255); } | ||
| body { transition: background-color 0.15s ease; } |
Member
There was a problem hiding this comment.
can you just move these to line 31-ish?
jrasm91
approved these changes
Jul 16, 2025
Member
|
Hmm, I think this PR is causing the spinner icon to display a black background that runs across the page when the web app is loading the source files 
You can reproduce by opening the network tab, then throttle to slow 4G, and reload the page. At first, it doesn't look like it has a background, but after some files finish loading, the background will show |
alextran1502
added a commit
that referenced
this pull request
Jul 24, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
…/reload (immich-app#19934) * prevent flashing white background in dark mode on page load/reload, tested with Safari and Chrome on macOS * integrate into existing FOUC-prevention --------- Co-authored-by: Evan <[email protected]>
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
…ge load/reload (immich-app#19934) (immich-app#20122) Revert "fix(web): prevent flashing white background in dark mode on page load/reload (immich-app#19934)" This reverts commit 32f23b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent flash of white background in dark mode on page load/reload by setting the background to dark in dark mode before page renders.
How Has This Been Tested?
Used "make dev" to build immich with change, and tested by repeatedly loading/reloading pages on Safari and Chrome. This was the minimal change that successfully removed the flash through white in dark mode.
API Changes
n/a
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)