chore: adjust setting subtitle to less clumsy expression #19970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated value for advanced_settings_prefer_remote_subtitle key to a less clumsy expression in the German translation.
Updated value for advanced_settings_prefer_remote_subtitle key to a less clumsy expression in the English translation.
bo0tzz
approved these changes
Jul 16, 2025
danieldietzler
approved these changes
Jul 16, 2025
Member
danieldietzler
left a comment
There was a problem hiding this comment.
Thanks! Would you mind making the German translation on weblate directly (https://hosted.weblate.org/projects/immich) instead? That would save us some headache :)
Member
|
Would you mind removing the German translation change from this PR then? :) |
This reverts commit e0c461f.
Contributor
Author
|
Hope this suits :) |
Member
|
Thanks! |
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the mobile app, the subtitle to the Prefer remote images toggle in advanced settings reads a bit clumsy.
I have adjusted the subtitle in both the English and German translations, but cannot verify other languages.
There is no open issue relating to this change.
How Has This Been Tested?
Not been tested. It's just a simple change.
If deemed unnecessary, feel free to reject!
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)