-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: more inclusive language #20092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more inclusive language #20092
Conversation
danieldietzler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make sense, thanks!
docs/docs/features/mobile-app.mdx
Outdated
|
|
||
| If the same asset is in more than one album it will only sync to the first album it's in, after that it won't sync again even if the user clicks sync albums manually. | ||
| To overcome this limitation, the files must be removed from the blacklist by | ||
| To overcome this limitation, the files must be removed from the ignorelist by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be more commonly used as ignore list so I'd suggest doing that as well
|
please squash the PR when merging, im doing these changes from my phone, so no rewriting history sadly 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed one :D Nope Github just lies lol
No worries we always squash PRs :) |
Description
This changes i18n to use more inclusive language. Generally I replace
blacklistwithblocklist, but in this case I thinkignorelistcaptures the feature better.I also adjusted the docs referencing it.
How Has This Been Tested?
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)