Skip to content

Conversation

@maybeanerd
Copy link
Contributor

@maybeanerd maybeanerd commented Jul 22, 2025

Description

This changes i18n to use more inclusive language. Generally I replace blacklist with blocklist, but in this case I think ignorelist captures the feature better.

I also adjusted the docs referencing it.

How Has This Been Tested?

  • No tests, as it's only a slight content change

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 22, 2025
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense, thanks!


If the same asset is in more than one album it will only sync to the first album it's in, after that it won't sync again even if the user clicks sync albums manually.
To overcome this limitation, the files must be removed from the blacklist by
To overcome this limitation, the files must be removed from the ignorelist by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be more commonly used as ignore list so I'd suggest doing that as well

@maybeanerd
Copy link
Contributor Author

please squash the PR when merging, im doing these changes from my phone, so no rewriting history sadly 😅

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one :D Nope Github just lies lol

@danieldietzler
Copy link
Member

please squash the PR when merging, im doing these changes from my phone, so no rewriting history sadly 😅

No worries we always squash PRs :)

@danieldietzler danieldietzler enabled auto-merge (squash) July 22, 2025 21:26
@danieldietzler danieldietzler merged commit f1cac12 into immich-app:main Jul 22, 2025
50 checks passed
ollioddi pushed a commit to ollioddi/immich that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:translation documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants