ordeq: static analysis of imports for FQNs
#413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordeq: static analysis of imports for FQNs
There was a problem hiding this comment.
Pull request overview
This PR introduces static analysis capabilities for extracting import information from Python modules to determine Fully Qualified Names (FQNs). The implementation adds a new internal module _static.py with functions to parse module source code and build import mappings.
Key changes:
- New
_static.pymodule with AST-based import parsing functions - Snapshot tests covering various example projects to validate import resolution
- Updated type checking snapshot reflecting reduced error count
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ordeq/src/ordeq/_static.py | New module implementing _module_to_ast and _module_to_imports functions for static import analysis using AST parsing |
| packages/ordeq/tests/resources/static/module_to_import_*.py | Test resources exercising import resolution across different project structures (rag pipeline, nested packages, etc.) |
| packages/ordeq/tests/snapshots/static/module_to_import_*.snapshot.md | Expected output snapshots validating correct import-to-module mapping for test cases |
| packages/ordeq/tests/snapshots/typing.snapshot.md | Updated snapshot showing fewer type checking errors (29 vs 32) with more files checked (280 vs 276) |
a30e004 to
4d31041
Compare
nielsneerhoff
approved these changes
Nov 24, 2025
Josersanvil
pushed a commit
to Josersanvil/ordeq
that referenced
this pull request
Nov 24, 2025
Josersanvil
pushed a commit
to Josersanvil/ordeq
that referenced
this pull request
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.