ordeq: support staticmethod in IOs
#429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for static methods in Input, Output, and IO classes by removing the validation that previously rejected staticmethod decorators on load() and save() methods.
Key changes:
- Removed staticmethod validation checks that raised "Load/Save method cannot be static" errors
- Refactored the
save()method parameter validation logic to handle both instance methods and staticmethods - Added test coverage for staticmethod usage in Input, Output, and IO classes
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ordeq/src/ordeq/_io.py | Removed staticmethod checks and refactored save() parameter validation to support staticmethods |
| packages/ordeq/tests/resources/io/io_static.py | New test demonstrating staticmethod usage with Input, Output, and IO classes |
| packages/ordeq/tests/snapshots/io/io_static.snapshot.md | Snapshot showing successful execution of staticmethod tests |
| packages/ordeq/tests/snapshots/io/io_static_load.snapshot.md | Removed error output that previously rejected staticmethod in Input |
| packages/ordeq/tests/snapshots/io/io_static_save.snapshot.md | Removed error output that previously rejected staticmethod in Output |
| packages/ordeq/tests/snapshots/typing.snapshot.md | Updated source file count from 284 to 285 files checked |
325f15d to
93c4979
Compare
nielsneerhoff
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.