-
Notifications
You must be signed in to change notification settings - Fork 7
ordeq-viz: use FQNs for nodes and IOs
#440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the codebase to use Fully Qualified Names (FQNs) more consistently, particularly in the visualization package. The changes improve code organization by consolidating node and IO processing logic and standardizing how FQNs are handled across the codebase.
Key changes:
- Consolidated node and IO processing into a new
process_nodes_and_iosfunction in_process_nodes_and_ios.py - Updated visualization code to use the
FQNclass instead of thefqn_to_object_reffunction for better type safety and clarity - Removed import aliases in test examples to ensure proper FQN resolution (e.g.,
b as B→b)
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
packages/ordeq/src/ordeq/_runner.py |
Refactored to use new process_nodes_and_ios function, removing inline validation and processing logic |
packages/ordeq/src/ordeq/_resolve.py |
Added _validate_runnables function (moved from _runner.py) for better code organization |
packages/ordeq/src/ordeq/_process_nodes_and_ios.py |
Added new process_nodes_and_ios function that consolidates runnable validation, resolution, and processing |
packages/ordeq-viz/src/ordeq_viz/graph.py |
Updated to use FQN class and properly handle FQNs from nodes, with type annotation added to _add_io_data parameter |
packages/ordeq-viz/src/ordeq_viz/api.py |
Updated to use process_nodes_and_ios function instead of separate processing steps |
packages/ordeq-test-examples/src/example_project/nodes_import_alias.py |
Removed import alias (b as B → b) to ensure correct FQN resolution |
packages/ordeq/tests/snapshots/runner/*.snapshot.md |
Updated stack traces to reflect new function call structure |
packages/ordeq-viz/tests/snapshots/**/*.snapshot.md |
Updated visualizations to show correct FQNs (e.g., b instead of B, example_3.nodes:f1 instead of example_3.func_defs:hello) |
ordeq-viz: use FQNs for nodesordeq-viz: use FQNs for nodes and IOs
No description provided.