Skip to content

Conversation

@sbrugman
Copy link
Collaborator

@sbrugman sbrugman commented Dec 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 1, 2025 10:54
@sbrugman sbrugman added the fix Something isn't working label Dec 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the ordeq package to automatically name anonymous inputs by deriving their fully qualified names (FQNs) from the function parameter names. This improves traceability and debugging by providing more meaningful names instead of generic IDs.

Key changes:

  • Adds _get_missing_io_fqns_from_parameters() function to derive FQNs from parameter names for IOs without existing FQNs
  • Updates logging output format to show named IOs (e.g., 'function_name:parameter_name') instead of generic ID references
  • Adds test coverage for the new naming functionality

Reviewed changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/ordeq/src/ordeq/_process_nodes_and_ios.py Implements core functionality to derive IO FQNs from function parameter names
packages/ordeq-test-examples/src/example_anonymous/node_with_var_names.py Adds test example with named parameters for anonymous inputs
packages/ordeq-viz/tests/resources/mermaid/viz_namespace.py Adds test resource to validate IO aliasing detection with new naming
packages/ordeq/tests/snapshots/**/*.snapshot.md Updates all snapshot tests to reflect new IO naming format in logging output
packages/ordeq-viz/tests/snapshots/mermaid/*.snapshot.md Updates visualization snapshots to show new IO naming in diagrams

@sbrugman sbrugman force-pushed the ordeq-io-inputs-keyword-names branch from 05d93ec to 8bf99fe Compare December 1, 2025 10:58
@sbrugman sbrugman force-pushed the ordeq-io-inputs-keyword-names branch from 8bf99fe to 473e532 Compare December 1, 2025 10:59
@sbrugman sbrugman merged commit 5af193b into main Dec 1, 2025
41 checks passed
@sbrugman sbrugman deleted the ordeq-io-inputs-keyword-names branch December 1, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants