uncap accelerate in requirements-cuda.txt (backport #628)
#634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fdfb4fd. This causes issues for downstream builders. Signed-off-by: Ken Dreyer <[email protected]> (cherry picked from commit c83f57b)
cdoern
approved these changes
Jul 2, 2025
Contributor
cdoern
left a comment
There was a problem hiding this comment.
LGTM, but we might be missing some other back ports? Or the failure may just be a flake
thisisatharva-rh
approved these changes
Jul 3, 2025
Contributor
|
The We're missing many fixes to the CI job on the We should try backporting all of |
Contributor
|
I've backported all the CI fixes to In the meantime, I don't think we should revert this PR. Instead, I think we should tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fdfb4fd.
This causes issues for downstream builders.
Fixes: #629
This is an automatic backport of pull request #628 done by Mergify.