feat(ui-toggle-details): rework ToggleGroup #2375
Open
+32
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7b7717 to
3a179c7
Compare
|
INSTUI-4882
3a179c7 to
7562481
Compare
ToMESSKa
commented
Jan 20, 2026
Comment on lines
226
to
+227
| await waitFor(() => { | ||
| svg = container.querySelector('svg')! |
Contributor
Author
There was a problem hiding this comment.
renderIconWithProps uses React.createElement, causing React to replace the SVG DOM node when icons change (instead of updating in place). The test held a stale reference to the old SVG.
ToMESSKa
commented
Jan 20, 2026
Comment on lines
+51
to
+55
| const toggleGroupSizeToIconSize = { | ||
| small: 'md', | ||
| medium: 'md', | ||
| large: 'lg' | ||
| } as const |
Contributor
Author
There was a problem hiding this comment.
@adamlobler can you check these sizes please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INSTUI-4882
ISSUE:
TEST PLAN: