Skip to content

Conversation

@DaughterOfMars
Copy link
Contributor

Description

Adds support for authenticating using an Abstract Account via a move authorization function. This PR adds basic support for constructing a Move Authenticator variant of the UserSignature and also convenience function to execute a transaction builder with the appropriate data.

@DaughterOfMars DaughterOfMars requested a review from a team as a code owner December 2, 2025 07:54
@DaughterOfMars DaughterOfMars marked this pull request as draft December 2, 2025 07:54
@coveralls
Copy link

coveralls commented Dec 2, 2025

Pull Request Test Coverage Report for Build 19863193474

Details

  • 88 of 257 (34.24%) changed or added relevant lines in 6 files are covered.
  • 19 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.05%) to 84.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/iota-sdk-crypto/src/multisig.rs 0 3 0.0%
crates/iota-sdk-types/src/crypto/signature.rs 12 16 75.0%
crates/iota-sdk-types/src/crypto/move_authenticator.rs 71 142 50.0%
crates/iota-sdk-transaction-builder/src/builder/mod.rs 1 92 1.09%
Files with Coverage Reduction New Missed Lines %
crates/iota-sdk-types/src/crypto/multisig.rs 2 73.71%
crates/iota-sdk-types/src/crypto/passkey.rs 2 81.88%
crates/iota-sdk-types/src/crypto/zklogin.rs 2 85.78%
crates/iota-sdk-types/src/lib.rs 3 76.47%
crates/iota-sdk-transaction-builder/src/lib.rs 5 95.61%
crates/iota-sdk-types/src/crypto/signature.rs 5 74.15%
Totals Coverage Status
Change from base Build 19819669021: -0.05%
Covered Lines: 21039
Relevant Lines: 24893

💛 - Coveralls

Bls12381 = 0x04,
ZkLogin = 0x05,
Passkey = 0x06,
Move = 0x07,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call it MoveAuthenticator please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The others aren't called that way though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's a good moment to rename them all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like that :c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not up to us, that's how it's called

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fiiine

@DaughterOfMars DaughterOfMars marked this pull request as ready for review December 2, 2025 15:03
@DaughterOfMars DaughterOfMars assigned Alex6323 and unassigned Alex6323 Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants