-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add Move Authenticator support #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19863193474Details
💛 - Coveralls |
| Bls12381 = 0x04, | ||
| ZkLogin = 0x05, | ||
| Passkey = 0x06, | ||
| Move = 0x07, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call it MoveAuthenticator please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The others aren't called that way though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's a good moment to rename them all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like that :c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not up to us, that's how it's called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fiiine
Description
Adds support for authenticating using an Abstract Account via a move authorization function. This PR adds basic support for constructing a Move Authenticator variant of the
UserSignatureand also convenience function to execute a transaction builder with the appropriate data.