chore(CI): Update homebrew formula on release #5433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
070d688 to
4bc4c6a
Compare
Member
|
Don't forget to update the confluence page when fully approved please |
…dger/iota into dev-tools/update-homebrew
Dr-Electron
reviewed
Mar 17, 2025
.github/workflows/release.yml
Outdated
| shell: bash | ||
| run: | | ||
| # Manual dispatch on a branch ref | ||
| if [ "${{ github.event_name == 'workflow_dispatch' }}" == "true" ]; then |
Contributor
There was a problem hiding this comment.
Am I stupid or does this check make no sense? The action only runs if the if condition of the job is met. But that checks for event_name == release 🤔
Contributor
Author
There was a problem hiding this comment.
Good call. I just copied this logic from the build job but you are right that this doesn't make sense
Co-authored-by: Thibault Martinez <[email protected]>
…dger/iota into dev-tools/update-homebrew
thibault-martinez
approved these changes
Mar 17, 2025
msarcev
approved these changes
Mar 18, 2025
Contributor
Author
Made the updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
update-homebrew-formulajob to the release workflow, which creates a PR on release in the https://github.com/iotaledger/homebrew-tap repository.Related Issues
Closes #5429