feat(compiler): add a new known attribute based on Flavor and move the attr logic into iota_mode #9187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e attr logic into iota_mode
|
The latest updates on your projects. Learn more about Vercel for GitHub. 6 Skipped Deployments
|
4 tasks
Dkwcs
reviewed
Nov 7, 2025
| // match self { | ||
| // Self::Attribute(a) => a.name(), | ||
| //} | ||
| unimplemented!() |
Contributor
There was a problem hiding this comment.
Why this is unimplemented and the function below as well?
valeriyr
approved these changes
Nov 11, 2025
edd0007
into
vm-lang/aa-auth/8116-feature-branch
36 of 42 checks passed
miker83z
added a commit
that referenced
this pull request
Nov 27, 2025
…e attr logic into iota_mode (#9187) # Description of change Added a generic FlavoredAttribute which can then allow us to define new attributes within the iota_mode compiler part. ## Links to any relevant issues Fixes #9186 ## How the change has been tested - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a generic FlavoredAttribute which can then allow us to define new attributes within the iota_mode compiler part.
Links to any relevant issues
Fixes #9186
How the change has been tested