Skip to content

Conversation

@wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Sep 1, 2025

Description of change

Add smaller updates and fixes to notarize shell script.

Details

  • add support for custom package ID
  • add JSON mode with reduced logs and output format = JSON
  • smaller fixes for calls/PTB
    • "@" prefix for PTB calls
    • drop pointy bracket around type for non-PTB calls
  • fix smaller typos

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Consumed script in another project and fixed errors, that occurred, and added features needed for integration (JSON mode, custom package).

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

@wulfraem wulfraem added bug Something isn't working enhancement New feature or request labels Sep 1, 2025
@eike-hass eike-hass moved this to Product Backlog in IOTA Trust Framework Developments Sep 1, 2025
@chrisgitiota
Copy link
Contributor

Generic side note: IMO we need to get away from this shell script and replace it with a CLI application implemented with Rust or TS. This - IMO - also applies to using large shell scripts in general.

@wulfraem wulfraem marked this pull request as ready for review September 3, 2025 05:59
@chrisgitiota chrisgitiota merged commit e12965d into main Sep 15, 2025
@github-project-automation github-project-automation bot moved this from Product Backlog to Done in IOTA Trust Framework Developments Sep 15, 2025
@itsyaasir itsyaasir deleted the feat/smaller-shell-script-updates branch September 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

4 participants