-
Notifications
You must be signed in to change notification settings - Fork 331
Implement EIP-1153: Transient storage #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe7c324 to
8ae3166
Compare
8ae3166 to
c497dfd
Compare
| case OP_DATALOADN: | ||
| case OP_DATASIZE: | ||
| case OP_DATACOPY: | ||
| case OP_TLOAD: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add them to EVMC already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped adding these to EVMC (e.g. MCOPY is missing). This seems double work with little benefits. Also EVMC instruction information is not directly usable by evmone because not constexpr.
What do you think about removing instructions from EVMC? This is a bit of work, but can be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably fine, if nobody uses them.
1cbbeff to
c7efc99
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 97.54% 97.56% +0.01%
==========================================
Files 91 92 +1
Lines 8473 8535 +62
==========================================
+ Hits 8265 8327 +62
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Looks good to me, needs rebase. |
c7efc99 to
c61f94a
Compare
d5c39ba to
13e210b
Compare
8410872 to
e391fa6
Compare
e391fa6 to
5da3bef
Compare
https://eips.ethereum.org/EIPS/eip-1153