Cannot read property 0 of undefined during index update fix#234
Open
flyinghuman wants to merge 2 commits intoiquidus:masterfrom
flyinghuman:master
Open
Cannot read property 0 of undefined during index update fix#234flyinghuman wants to merge 2 commits intoiquidus:masterfrom flyinghuman:master
flyinghuman wants to merge 2 commits intoiquidus:masterfrom
flyinghuman:master
Conversation
Collaborator
|
@flyinghuman why aren't there any addresses? Looks like an easy merge but wondering what the cause is, not seen this. @uaktags have you? |
Collaborator
Collaborator
|
This has been hanging around since #56 I'm just not sure if the fix in this PR is good enough or we need to handle it better? |
Collaborator
|
It's an easy fix indeed, but the problems seem to be related to coin specific anomalies. It may be more suited to later look into coin-specific parsing objects that we call during these checks. Basically we do checks against what the coin allows, and either skip over all of it to do a save_tx without vins/vouts or proceed with them. Not exactly sure how to do that cleanly though as already just typing it out sounds pretty stupid and intensive of a process for the sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes the error during index update if there are no adresses.