Fix win32 test failure #303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this fix, I believe many of the PRs of recent will pass the tests now. Hopefully you get merged sooner than later. |
Contributor
Author
|
@raygervais All due respect to the maintainer, but it looks like he doesn't get around to handling issues/PRs very often. Kind of troubling, if you think about the very many packages depending on this. |
Closed
11 tasks
|
@isaacs As part of my follow-up from npm/node-semver#244 this PR would allow unskipping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in
eperm-stat.jsfails on Appveyor because the fixtures don't include symlinks. This PR remedies that.