Skip to content

v4.1.3: [security] Fix crash on redirect with formfeed in URL (CVE-2019-10775) #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2020
Merged

v4.1.3: [security] Fix crash on redirect with formfeed in URL (CVE-2019-10775) #266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3491a
[minor] Remove else-after-return to make eslint pass
mk-pmb Apr 1, 2020
d37b507
v4.1.3: [security] Fix crash on redirect with formfeed in URL (CVE-20…
mk-pmb Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[minor] Remove else-after-return to make eslint pass
  • Loading branch information
@mk-pmb
mk-pmb committed Apr 1, 2020
commit fd3491a42f6f2804b9816116183d79ae963f5c81
3 changes: 2 additions & 1 deletion lib/ecstatic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ module.exports = function createMiddleware(_dir, _options) {
if (opts.weakCompare && clientEtag !== serverEtag
&& clientEtag !== `W/${serverEtag}` && `W/${clientEtag}` !== serverEtag) {
return false;
} else if (!opts.weakCompare && (clientEtag !== serverEtag || clientEtag.indexOf('W/') === 0)) {
}
if (!opts.weakCompare && (clientEtag !== serverEtag || clientEtag.indexOf('W/') === 0)) {
return false;
}
}
Expand Down