fix: resolve Lahman data loading and remove debug output#497
Open
nicko4o wants to merge 1 commit intojldbc:masterfrom
Open
fix: resolve Lahman data loading and remove debug output#497nicko4o wants to merge 1 commit intojldbc:masterfrom
nicko4o wants to merge 1 commit intojldbc:masterfrom
Conversation
- lahman.py: Update URL from deprecated chadwickbureau to seanlahman - lahman.py: Add Master.csv/People.csv fallback for compatibility - team_results.py: Remove debug print(url) statement Fixes: jldbc#489 (Lahman loading)
There was a problem hiding this comment.
Pull request overview
This PR fixes a 404 error when loading Lahman baseball database data and removes a debug print statement.
- Updated Lahman database repository URL from deprecated
chadwickbureau/baseballdatabankto workingseanlahman/baseballdatabank - Added backwards compatibility for older database versions that use
Master.csvinstead ofPeople.csv - Removed debug print statement from team results module
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pybaseball/lahman.py | Updated URL to working repository and added fallback for legacy file naming |
| pybaseball/team_results.py | Removed debug print statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Lahman database loading (404 error) and remove debug print statement.
Changes
chadwickbureau/baseballdatabankURL to workingseanlahman/baseballdatabankMaster.csvfallback for compatibility with older database versionsprint(url)statementRelated Issues
Fixes #489 (Lahman data loading)
Testing