Skip to content

Fix the enums PoolingType and RopeScalingType values and their calls in ModelParameters #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Pierrlf
Copy link
Contributor

@Pierrlf Pierrlf commented Apr 28, 2025

Most LLMs expect a string describing the pooling type and rope scaling type parameters, rather than an integer.
Previously, using integers resulted in unrecognized or invalid values.

This pull request corrects the issue by:
- Updating the PoolingType and RopeScalingType enums to use string values instead of integers.
- Adjusting their usage accordingly in the ModelParameters class.

@kherud
Copy link
Owner

kherud commented May 9, 2025

Hey @Pierrlf thanks for the PR, looks good to me

@kherud kherud merged commit cc139bb into kherud:master Jun 20, 2025
4 checks passed
@kherud
Copy link
Owner

kherud commented Jun 20, 2025

Thanks again for PR, sorry that it took a while, I was to busy with other stuff. I'll release a new version with the changes soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants