Use the Machine Type Selector table - Azure#7768
Merged
kubermatic-bot merged 2 commits intokubermatic:mainfrom Feb 11, 2026
Merged
Use the Machine Type Selector table - Azure#7768kubermatic-bot merged 2 commits intokubermatic:mainfrom
kubermatic-bot merged 2 commits intokubermatic:mainfrom
Conversation
Contributor
Author
|
/retest |
1b1bcb7 to
35cab25
Compare
35cab25 to
cadb028
Compare
8 tasks
KhizerRehan
reviewed
Feb 10, 2026
| vm.ResourceDiskSizeInMB = safeInt(cap.Value) | ||
| } | ||
| if *cap.Name == "MemoryGB" { | ||
| vm.MemoryInMB = safeInt(cap.Value) * 1024 |
Contributor
There was a problem hiding this comment.
Just wanted to double check that Smaller VM's if values are returned like in floating number this method would fail?
what if value is greater then 1 but still fractional?
strconv.Atoi("0.75") → error → 0
strconv.Atoi("1.75") → error → 0
strconv.Atoi("3.5") → error → 0
strconv.Atoi("4.0") → error → 0
I assume all values are returned as strict "int" values in which it will be able to parse then correctly.
Contributor
Author
There was a problem hiding this comment.
im not sure so maybe it's better to fix that.
KhizerRehan
reviewed
Feb 10, 2026
Contributor
|
Please try to keep one issue per PR. This helps when discussion or backporting is needed (e.g. #7605). if it’s not an issue, please mark it resolved and i will remove unhold. |
Contributor
|
/approve |
Contributor
|
LGTM label has been added. DetailsGit tree hash: b6bf52a9d12e04af2c9a7d952c3b1312e15aa997 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KhizerRehan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/hold |
cadb028 to
17fe4ec
Compare
17fe4ec to
8100c4d
Compare
Contributor
|
/unhold |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 5a95559171463ada07f1a800dd030a46535942f8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Frontend / UI
Backend / API
Which issue(s) this PR fixes:
Fixes #7755 #7605
What type of PR is this?
/kind design
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: